Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invlerp
andremap
implementation #2654invlerp
andremap
implementation #2654Changes from 16 commits
1975b07
3e6fe92
4f9ca04
1b196b8
7e20fb8
66c817f
cf51bf6
a291038
f5524ef
f557983
5f41e95
0f552cd
3f83b7f
d2b053b
969b2b0
3868b04
386ab80
99d0682
93aa1a9
43dc68f
849b739
8960d02
a542c8f
3078c72
dad6326
5bcdf35
1ce7019
cbf66ef
bbcdeef
64461ed
a87b274
a27e44d
fce1693
ff7dc3d
85e64e3
964fdbd
9d483ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improvement suggestion: instead of checking this explicitly, we can instead call
PyFloat_AsDouble
directly, and then handle the error on a per-argument basis? That we can also tell which of the arguments is incorrectThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So If I understood, I should write something like this ? :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we could do a simple
return NULL
as the error is already set. But the error won't be really specific