Improved Window.flip error message when no surface is associated with the Window
#2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matiiss
changed the title
Window.flip error message when no surface is associated with itWindow.flip error message when no surface is associated with the Window
Starbuck5
reviewed
Jan 4, 2024
Starbuck5
reviewed
Jan 4, 2024
Matiiss
force-pushed
the
matiiss-improve-window-flip-err-msg
branch
from
b738989 to
f97d3c0
Compare
ankith26
approved these changes
Jan 7, 2024
Starbuck5
added a commit
that referenced
this pull request
Feb 18, 2024
…-msg Improved `Window.flip` error message when no surface is associated with the `Window`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the error message would have been
"Window surface is invalid, please call SDL_GetWindowSurface() to get a new surface"This also adds a video init check, which is related to this issue: #2605
But I don't know if it should stay here, because if, for instance, we implicitly init video on Window creation, this check shouldn't be needed here?