-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pygame.version
to not be an autogen file
#2537
Conversation
31d0b51
to
34599b7
Compare
34599b7
to
75651d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
One minor stub thing that could be fixed.
Do we need |
The CI is still failing, for now I will take the easier approach of excluding the |
I think I just needed to add:
But don't mind pulling it out of the base namespace stubgen either. |
ac19c0a
to
80c0032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The idea here is to simplify buildconfig a tiny bit.
Instead of having
pygame.version
auto-generated bysetup.py
on every build (by doing a hacky lookup into C sources), the version information would be exported viapygame.base
as a regular python string.Also improved tests a bit.