Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translation #2430

Merged
merged 11 commits into from
Sep 21, 2023
Merged

Spanish Translation #2430

merged 11 commits into from
Sep 21, 2023

Conversation

Carbon32
Copy link
Contributor

This will basically add Spanish language to the README section. I've checked for any issues it seems to integrate fine.

@Carbon32 Carbon32 requested a review from a team as a code owner August 30, 2023 18:12
@yunline yunline added the docs label Aug 31, 2023
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me, thanks @Carbon32.

It would be nice to get another Spanish speaker to proofread, additionally.

Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and translation!

The readme is understandable as it is. I only found some punctuation and maybe some sentences that address the user in a different mode ('usted' vs 'tu'). But that might be some nitpicking or even the normal way to express those in Spanish.

docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
@Carbon32
Copy link
Contributor Author

Thanks for the PR and translation!

The readme is understandable as it is. I only found some punctuation and maybe some sentences that address the user in a different mode ('usted' vs 'tu'). But that might be some nitpicking or even the normal way to express those in Spanish.

I hope everything is well written now, Give me a heads up if you see anything else.

@Carbon32 Carbon32 requested a review from dr0id September 18, 2023 16:35
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
@Matiiss
Copy link
Member

Matiiss commented Sep 21, 2023

Besides that one little thing, as much as I could check the translation using Google Translate, it seemed fine.

@Carbon32 Carbon32 requested a review from Matiiss September 21, 2023 10:58
docs/readmes/README.es.rst Outdated Show resolved Hide resolved
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from that tiny change to revert

docs/readmes/README.es.rst Outdated Show resolved Hide resolved
@Matiiss Matiiss merged commit e87dd4d into pygame-community:main Sep 21, 2023
@Carbon32 Carbon32 deleted the es-translation branch September 21, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants