transform.solid_overlay

[ScriptLineStudios]

closes #1847

import pygame

dis = pygame.display.set_mode((600, 600))

img = pygame.image.load("transparent_walt.png")
img = pygame.transform.solid_overlay(img, (0, 0, 0))

while True:
    dis.fill((100, 100, 100))

    for event in pygame.event.get():
        if event.type == pygame.QUIT:
            raise SystemExit

    dis.blit(img, (30, 30))
    pygame.display.update()

produces:

[ankith26]

That isn't really this PRs fault, though it's something I plan to tackle in the near future

[itzpr3d4t0r]

As per @ScriptLineStudios on Discord I'll take over this PR.

[MyreMylar]

OK, LGTM.

All works locally for me, I like the keep_alpha flag and I can think of lots of uses for this in games. Also everything is passing CI now and the docs make sense.

I'm not sure there is much scope for SIMD in this transform either as it is a per pixel branch rather than any mathematical operation on every pixel.

Happy to see this go in.

[damusss]

I think the message I sent on discord got lost, so I'm typing it here instead.
Basically providing a string color such as "green" raises a TypeError: invalid search_color argument, which is not expected as the argument supports ColorValue, and the error is also referring to a non existent parameter search_color

On a side note, I'd like for this function to have some kind of alpha threshold parameter, but it's fine if it doesn't (the first time I tested my image had an alpha of 6 which I wasn't aware of, and I had to open an image editing program to bring it to 0 before trying again.)

[damusss]

the search_color in the error is still present but this is such a small nitpick that I'm approving anyways. I'm gonna let some SR or SC member merge it as this is new api. LGTM, and works locally.

[ankith26]

This line is too long, maybe you could re-format this file with black/ruff?

[itzpr3d4t0r]

This should be fixed now thanks.

[ankith26]

Why is it an unmatched lock here?

[itzpr3d4t0r]

This is the original sin lol, always been there so it became invisible to my eyes, should be fixed now.

[damusss]

@itzpr3d4t0r after typing.py, ColorValue isn't available anymore. If you can you can update the branch and replace ColorValue with ColorLike from pygame.typing

[itzpr3d4t0r]

@itzpr3d4t0r after typing.py, ColorValue isn't available anymore. If you can you can update the branch and replace ColorValue with ColorLike from pygame.typing

I'm not sure i can do it right atm. I've always committed from github because of commit permissions being broken in my ide for some reason... so I'm afraid someone else has to do it.