Clean up ScancodeWrapper #2170
Closed
Clean up ScancodeWrapper #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldalma999
force-pushed
the
scancodewrapper-cleanup
branch
from
2c160f0 to
92f5628
Compare
yunline
added
Code quality/robustness
|
I'll be closing this for now, but I do plan to reopen something like this in the future. I will, however, definitely wait for #1912 to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when PurityLake added errors to
ScancodeWrapper's iter functions, I noticed that the code for the class is repetitive at places, and could be cleaned up. So I did it (about 3 months ago, and then never made a pr out of it). Technically this implementation should also be faster at creating the object as well, but since this is a small optimization, it is not like this is going to speed up anything significantly. Accessing times should be around the same though (again, not that it matter much).