Reduce errors in src_c/surface.c when compiling with SDL3 #3633

	name: cppcheck Static Analysis

	# Run cppcheck on src_c changes to main branch, or any PR to main.
	on:
	push:
	branches: main
	paths:
	- 'src_c/**'

	pull_request:
	branches: main
	paths:
	- 'src_c/**'

	concurrency:
	group: ${{ github.workflow }}-${{ github.ref }}-cppcheck
	cancel-in-progress: true

	# TODO: Any more static checkers can be added here
	jobs:
	run-cppcheck:
	runs-on: ubuntu-24.04

	steps:
	- uses: actions/[email protected]

	- name: Install deps
	# https://github.com/actions/runner-images/issues/7192
	# https://github.com/orgs/community/discussions/47863
	run: \|
	sudo apt-get update --fix-missing
	sudo apt install cppcheck

	- name: Run Static Checker
	# skip cppcheck on SDL_gfx, scrap, scale_mm* and ft_cache for now
	# suppress missingReturn and syntaxError because it gives many false positives
	run: cppcheck src_c --enable=performance,portability,warning \
	--suppress=:src_c/freetype/ft_cache.c --suppress=:src_c/scrap* \
	--suppress=:src_c/scale_mmx.c --suppress=:src_c/SDL_gfx/ \
	--suppress=missingReturn --suppress=syntaxError -DWITH_THREAD -j $(nproc) \
	-DPG_MAJOR_VERSION -DPG_MINOR_VERSION -DPG_PATCH_VERSION -DPG_VERSION_TAG

Provide feedback