Add nn.models.GRetriever
#9480
Merged
Add nn.models.GRetriever
#9480
+416
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9480 +/- ##
==========================================
+ Coverage 86.93% 87.39% +0.46%
==========================================
Files 464 478 +14
Lines 30755 31236 +481
==========================================
+ Hits 26737 27299 +562
+ Misses 4018 3937 -81 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
puririshi98
changed the title
GRetriever model integration
This was referenced Jul 7, 2024
Merged
Merged
rusty1s
reviewed
Jul 8, 2024
will merge this in when its ready to address #9480 (comment) halfway done modularizing --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@rusty1s @akihironitta anything else needed to merge the 3 remaining PRs? |
zechengz
reviewed
Aug 17, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Sep 10, 2024
|
Very clean now, thanks for the updates :) |
rusty1s
added a commit
that referenced
this pull request
Sep 13, 2024
1. #9462 2. #9480 3. **->** #9481 4. #9167 --- Breaking down PR #9167 further --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: rusty1s <[email protected]>
rusty1s
added a commit
that referenced
this pull request
Sep 13, 2024
1. #9462 2. #9480 3. #9481 4. **->** #9167 --- repro: Latest NVIDIA PyG container + `git config --global credential.helper store; huggingface-cli login; cd /opt/pyg; pip uninstall -y torch-geometric; rm -rf pytorch_geometric; git clone -b gnn-llm-model-integration https://github.com/pyg-team/pytorch_geometric.git; cd /opt/pyg/pytorch_geometric; pip install .; pip install peft datasets transformers pcst_fast sentencepiece; python3 examples/llm_plus_gnn/g_retriever.py` old PR: #9154 note: pure cpu is 220x slower than pure GPU using a single Grace Hopper (for llama-7b) info: tried gemma, performs worse in all train/val/test metrics. most likely needs some tuning, will leave this as future work as part of the community sprint to try many LLM and GNN combos and tune them. Therefore keeping the default llama2 the new gemma-v2 is also much worse than llama2 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akihiro Nitta <[email protected]> Co-authored-by: rusty1s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLMclass #9462nn.models.GRetriever#9480WebQSPDataset#9481breaking #9167 down further, focusing on G-retriever model this time