Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow None outputs in FeatureStore #9102

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Allow None outputs in FeatureStore #9102

merged 2 commits into from
Mar 26, 2024

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Mar 26, 2024

Moves any KeyError logic to _get_tensor()

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.58%. Comparing base (ceeea03) to head (3847f4b).

Files Patch % Lines
torch_geometric/data/feature_store.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9102   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         470      470           
  Lines       30160    30160           
=======================================
  Hits        27018    27018           
  Misses       3142     3142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit c75c719 into master Mar 26, 2024
16 of 17 checks passed
@rusty1s rusty1s deleted the allow_none_in_fs branch March 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant