-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGBMAG240m
example
#8249
OGBMAG240m
example
#8249
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@akihironitta lmk if theres anything else needed to merge this, we have been using this internally and in our containers for some time now, it would be great for all PyG users to have access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puririshi98 It would also be nice to add a quick docstring of the model args.
Also, would it make sense to have this script in examples/multi_gpu/
and add examples/multi_gpu/README.md
briefly describing what each of the multi-gpu scripts (that you recently added) does and/or how each example differs from each other?
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
for more information, see https://pre-commit.ci
@akihironitta addressd, ur comments, lmk if you have any further review requests |
@rusty1s @akihironitta lmk if there is anything else i would need to get this merge ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll just keep my review a "comment" as I'd like to run this in my env, too :) Feel free to ask Matthias to merge if I'm too slow ;)
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
for more information, see https://pre-commit.ci
@akihironitta thanks for the review, no rush, please merge once your ready. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Note that you also need to call acc.reset()
in order to avoid sharing metrics between training/validation.
Epoch: 20, Step: 1000, Loss: 0.8472, Train Acc: 72.31%, Most Recent Step Time: 0.1662s
Epoch: 20, Loss: 0.8822, Train Acc:72.31%, Average Step Time: 0.1624s
Validation Accuracy: 68.7001%
Test Accuracy: 68.6972%
PR finally ready, test accuracy is on par with claimed accuracies in OGB repo