Add spmm and is_torch_sparse_tensor
#5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 tasks
Codecov Report
@@ Coverage Diff @@
## master #5906 +/- ##
==========================================
- Coverage 86.41% 84.41% -2.00%
==========================================
Files 349 351 +2
Lines 19507 19518 +11
==========================================
- Hits 16857 16477 -380
- Misses 2650 3041 +391
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
reviewed
Nov 7, 2022
| from torch_geometric.utils import is_torch_sparse_tensor | ||
|
|
||
|
|
||
| def spmm(src: SparseTensor, other: Tensor, reduce: str = "sum") -> Tensor: |
There was a problem hiding this comment.
Can we make this TorchScript compatible via the overload decorator?
Co-authored-by: Matthias Fey <[email protected]>
rusty1s
approved these changes
Nov 9, 2022
|
Thanks @rusty1s for the updates and making it merged :) |
JakubPietrakIntel
pushed a commit
to JakubPietrakIntel/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
This PR implements: + `spmm` function for both PyTorch and torch_sparse SparseTensor + `is_torch_sparse_tensor` function to check if a tensor is a PyTorch SparseTensor TODO: + Add test and docstring for `spmm` Any comments would be appreciated :) Co-authored-by: Matthias Fey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
spmmfunction for both PyTorch and torch_sparse SparseTensoris_torch_sparse_tensorfunction to check if a tensor is a PyTorch SparseTensorTODO:
spmmAny comments would be appreciated :)