Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Hints] nn.RENet #5715

Merged
merged 12 commits into from
Oct 17, 2022
Merged

[Type Hints] nn.RENet #5715

merged 12 commits into from
Oct 17, 2022

Conversation

TanveshT
Copy link
Contributor

Changes

  • added type hints to nn.RENet
  • added unit-test using TorchScript to test_re_net.py

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #5715 (1607b07) into master (311cae0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1607b07 differs from pull request most recent head cfec045. Consider uploading reports for the commit cfec045 to get more accurate results

@@           Coverage Diff           @@
##           master    #5715   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         349      349           
  Lines       19315    19318    +3     
=======================================
+ Hits        16233    16236    +3     
  Misses       3082     3082           
Impacted Files Coverage Δ
torch_geometric/nn/models/re_net.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TanveshT TanveshT marked this pull request as ready for review October 15, 2022 09:38
test/nn/models/test_re_net.py Outdated Show resolved Hide resolved
test/nn/models/test_re_net.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/re_net.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/re_net.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/re_net.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/re_net.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/re_net.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 17, 2022 06:28
@rusty1s rusty1s merged commit ee09efe into pyg-team:master Oct 17, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
## Changes

- added type hints to `nn.RENet`
- added unit-test using TorchScript to `test_re_net.py`

Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants