Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.GraphUNet and nn.SchNet #5710

Merged
merged 15 commits into from
Oct 15, 2022
Merged

[Type Hints] nn.GraphUNet and nn.SchNet #5710

merged 15 commits into from
Oct 15, 2022

Conversation

TanveshT
Copy link
Contributor

Changes

  • added type hints to nn.GraphUNet & nn.SchNet
  • added unit-tests to test/nn/models/test_graph_unet.py & test/nn/models/test_schnet.py

@TanveshT TanveshT marked this pull request as draft October 15, 2022 05:45
@TanveshT TanveshT marked this pull request as ready for review October 15, 2022 06:28
@codecov
Copy link

codecov bot commented Oct 15, 2022 •
edited
Loading

Codecov Report

Merging #5710 (a23fda4) into master (e9991b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a23fda4 differs from pull request most recent head d396bff. Consider uploading reports for the commit d396bff to get more accurate results

@@           Coverage Diff           @@
##           master    #5710   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         349      349           
  Lines       19276    19282    +6     
=======================================
+ Hits        16194    16200    +6     
  Misses       3082     3082
Impacted Files Coverage Δ
torch_geometric/nn/models/graph_unet.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/schnet.py 69.75% <100.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s mentioned this pull request Oct 15, 2022
Closed
rusty1s
rusty1s reviewed Oct 15, 2022
View reviewed changes
torch_geometric/nn/models/graph_unet.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/schnet.py Outdated Show resolved Hide resolved
torch_geometric/nn/models/schnet.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 15, 2022 07:24
@rusty1s rusty1s changed the title [Type Hints] nn.GraphUNet nn.SchNet [Type Hints] nn.GraphUNet and nn.SchNet Oct 15, 2022
@rusty1s rusty1s merged commit 52bf94b into pyg-team:master Oct 15, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@TanveshT @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] nn.GraphUNet nn.SchNet (pyg-team#5710)
3de7710 
## Changes

- added type hints to `nn.GraphUNet` & `nn.SchNet`
- added unit-tests to `test/nn/models/test_graph_unet.py` &
`test/nn/models/test_schnet.py`

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@TanveshT TanveshT

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanveshT @rusty1s