Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] datasets.ModelNet #5701

Merged
merged 10 commits into from
Oct 15, 2022
Merged

[Type Hints] datasets.ModelNet #5701

merged 10 commits into from
Oct 15, 2022

Conversation

RamachandranSitaraman
Copy link
Contributor

Added TypeHints

@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #5701 (400c670) into master (753d1e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 400c670 differs from pull request most recent head 301c9cc. Consider uploading reports for the commit 301c9cc to get more accurate results

@@            Coverage Diff             @@
##           master    #5701      +/-   ##
==========================================
- Coverage   83.83%   83.83%   -0.01%     
==========================================
  Files         349      349              
  Lines       19276    19273       -3     
==========================================
- Hits        16160    16157       -3     
  Misses       3116     3116
Impacted Files Coverage Δ
torch_geometric/nn/pool/avg_pool.py 100.00% <0.00%> (ø)
torch_geometric/transforms/random_shear.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title [Type Hints] {ModelNet} [Type Hints] datasets.ModelNet Oct 14, 2022
rusty1s
rusty1s approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we also track this change in CHANGELOG.md?

torch_geometric/datasets/modelnet.py Outdated Show resolved Hide resolved
torch_geometric/datasets/modelnet.py Outdated Show resolved Hide resolved
torch_geometric/datasets/modelnet.py Outdated Show resolved Hide resolved
torch_geometric/datasets/modelnet.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 15, 2022 06:43
@rusty1s rusty1s merged commit 2a64140 into pyg-team:master Oct 15, 2022
@rusty1s rusty1s mentioned this pull request Oct 15, 2022
Closed
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@RamachandranSitaraman @RamachandranSitaraman-hv
@pre-commit-ci @rusty1s @JakubPietrakIntel
[Type Hints] datasets.ModelNet (pyg-team#5701)
76585e1 
Added TypeHints

Co-authored-by: vsitaraman <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@RamachandranSitaraman RamachandranSitaraman

Labels
0 - Priority P0 dataset type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RamachandranSitaraman @rusty1s @RamachandranSitaraman-hv