Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] transforms.Polar #5676

Merged
merged 3 commits into from
Oct 13, 2022
Merged

[Type Hints] transforms.Polar #5676

merged 3 commits into from
Oct 13, 2022

Conversation

EdisonLeeeee
Copy link
Contributor

No description provided.

@EdisonLeeeee EdisonLeeeee self-assigned this Oct 13, 2022
@EdisonLeeeee EdisonLeeeee mentioned this pull request Oct 13, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5676 (7e91fd3) into master (43f9df2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7e91fd3 differs from pull request most recent head b90a69a. Consider uploading reports for the commit b90a69a to get more accurate results

@@           Coverage Diff           @@
##           master    #5676   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files         349      349           
  Lines       19245    19247    +2     
=======================================
+ Hits        16116    16118    +2     
  Misses       3129     3129
Impacted Files Coverage Δ
torch_geometric/transforms/polar.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

wsad1
wsad1 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Gentle reminder to add update changelog.

@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 08:53
@EdisonLeeeee
Copy link
Contributor Author

Thanks @rusty1s for updating the changelog. I intended to add it after another PR has been merged to avoid conflicts.

@rusty1s rusty1s merged commit bd6b37e into master Oct 13, 2022
@rusty1s rusty1s deleted the type_hints_polar branch October 13, 2022 08:57
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@EdisonLeeeee @rusty1s @JakubPietrakIntel
[Type Hints] transforms.Polar (pyg-team#5676)
c9a7d4e 
Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 wsad1 approved these changes

@rusty1s rusty1s rusty1s approved these changes

Assignees

@EdisonLeeeee EdisonLeeeee

Labels
0 - Priority P0 transform type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdisonLeeeee @rusty1s @wsad1