Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] transforms.LocalCartesian #5675

Merged
merged 2 commits into from
Oct 13, 2022
Merged

[Type Hints] transforms.LocalCartesian #5675

merged 2 commits into from
Oct 13, 2022

Conversation

EdisonLeeeee
Copy link
Contributor

No description provided.

@EdisonLeeeee EdisonLeeeee self-assigned this Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5675 (68da94b) into master (faca580) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5675   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files         349      349           
  Lines       19244    19245    +1     
=======================================
+ Hits        16115    16116    +1     
  Misses       3129     3129
Impacted Files Coverage Δ
torch_geometric/transforms/local_cartesian.py 95.83% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EdisonLeeeee EdisonLeeeee mentioned this pull request Oct 13, 2022
Closed
wsad1
wsad1 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rusty1s rusty1s merged commit 43f9df2 into master Oct 13, 2022
@rusty1s rusty1s deleted the type_hints_local_cartesian branch October 13, 2022 08:52
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@EdisonLeeeee @JakubPietrakIntel
[Type Hints] transforms.LocalCartesian (pyg-team#5675)
c0d5e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 wsad1 approved these changes

@rusty1s rusty1s rusty1s approved these changes

Assignees

@EdisonLeeeee EdisonLeeeee

Labels
0 - Priority P0 transform type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdisonLeeeee @rusty1s @wsad1