Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeHints] ToDense #5668

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Conversation

sebastian-montero
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #5668 (7178db5) into master (c466ffc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7178db5 differs from pull request most recent head 6b0dd88. Consider uploading reports for the commit 6b0dd88 to get more accurate results

@@           Coverage Diff           @@
##           master    #5668   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         349      349           
  Lines       19232    19233    +1     
=======================================
+ Hits        16129    16130    +1     
  Misses       3103     3103           
Impacted Files Coverage Δ
torch_geometric/transforms/to_dense.py 100.00% <100.00%> (ø)
torch_geometric/utils/isolated.py 100.00% <0.00%> (ø)
torch_geometric/utils/normalized_cut.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sebastian-montero
Copy link
Contributor Author

Note that TorchScript still doesn't support variable number of arguments *args

E           torch.jit.frontend.NotSupportedError: Compiled functions can't take variable number of arguments or use keyword-only arguments with defaults:
E             File "/Users/sebastianmontero/Desktop/pytorch_geometric/torch_geometric/data/data.py", line 735
E               def __call__(self, *args: List[str]) -> Iterable:
E                                  ~~~~~ <--- HERE
E                   r"""Iterates over all attributes :obj:`*args` in the data, yielding
E                   their attribute names and values.

@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 06:39
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s merged commit bdd11e3 into pyg-team:master Oct 13, 2022
@sebastian-montero sebastian-montero deleted the type_hints/ToDense branch October 13, 2022 07:22
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants