Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] utils.remove_isolated_nodes #5659

Merged
merged 9 commits into from
Oct 13, 2022
Merged

[Type Hints] utils.remove_isolated_nodes #5659

merged 9 commits into from
Oct 13, 2022

Conversation

LukeLIN-web
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2022 •
edited
Loading

Codecov Report

Merging #5659 (7a9722e) into master (5f1e0a8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7a9722e differs from pull request most recent head 3daea1f. Consider uploading reports for the commit 3daea1f to get more accurate results

@@           Coverage Diff           @@
##           master    #5659   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         349      349           
  Lines       19231    19231           
=======================================
  Hits        16128    16128           
  Misses       3103     3103
Impacted Files Coverage Δ
torch_geometric/utils/isolated.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lightaime lightaime changed the title [Type Hints] utils.remove_isolated_nodes [Type Hints] utils.remove_isolated_nodes Oct 12, 2022
lightaime
lightaime reviewed Oct 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
EdisonLeeeee
EdisonLeeeee reviewed Oct 12, 2022
View reviewed changes
torch_geometric/utils/isolated.py Outdated Show resolved Hide resolved
torch_geometric/utils/isolated.py Outdated Show resolved Hide resolved
rusty1s
rusty1s approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
torch_geometric/utils/isolated.py Outdated Show resolved Hide resolved
torch_geometric/utils/isolated.py Show resolved Hide resolved
@rusty1s rusty1s mentioned this pull request Oct 13, 2022
Closed
@rusty1s rusty1s enabled auto-merge (squash) October 13, 2022 06:22
@rusty1s rusty1s merged commit 0acbed7 into pyg-team:master Oct 13, 2022
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@LukeLIN-web @pre-commit-ci
@EdisonLeeeee @rusty1s @JakubPietrakIntel
[Type Hints] utils.remove_isolated_nodes (pyg-team#5659)
fd0c988 
Co-authored-by: juyi.lin <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jintang Li <[email protected]>
Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdisonLeeeee EdisonLeeeee EdisonLeeeee left review comments

@lightaime lightaime lightaime left review comments

@rusty1s rusty1s rusty1s approved these changes

Assignees

@LukeLIN-web LukeLIN-web

Labels
0 - Priority P0 type hints utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukeLIN-web @rusty1s @lightaime @EdisonLeeeee