refactor(loader): HGTLoader behind NodeLoader interface, part 5
#5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric into remote_backend_4
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5418 +/- ##
=======================================
Coverage 85.31% 85.31%
=======================================
Files 345 345
Lines 18824 18824
=======================================
Hits 16060 16060
Misses 2764 2764 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ric into remote_backend_6
mananshah99
changed the title
HGTLoader behind NodeLoader interfaceHGTLoader behind NodeLoader interface, part 5
rusty1s
approved these changes
Sep 13, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #5404 by refactoring
HGTLoaderbehind the sampler and loader interface; the simplicity of this refactor also shows the flexibility of the interface. In doing so, it definesHGTSamplerthat inherits fromBaseSampler, and usesHGTSampleras part of theHGTLoader(NodeLoader)construction. With this setup, it should also be trivial to add an HGT link-level loader, but this task is left as a TODO.