Support normalization_resolver in MLP
#4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4951 +/- ##
==========================================
- Coverage 84.66% 82.71% -1.95%
==========================================
Files 330 330
Lines 17890 17891 +1
==========================================
- Hits 15146 14799 -347
- Misses 2744 3092 +348
Continue to review full report at Codecov.
|
lightaime
changed the title
normalization_resolver in MLPnormalization_resolver in MLP
Padarn
reviewed
Jul 10, 2022
torch_geometric/nn/models/mlp.py
Outdated
| act_first = act_first or kwargs.get("relu_first", False) | ||
| batch_norm = kwargs.get("batch_norm", None) | ||
| if batch_norm is not None and isinstance(batch_norm, bool): | ||
| warnings.warn("Argument `batch_norm` will be deprecated, " |
There was a problem hiding this comment.
I'm wondering if we should decide on a version in which it will be depreciated and note that here? WDYT?
There was a problem hiding this comment.
I am not sure when we want to fully deprecate it though. @rusty1s any idea on this?
Padarn
reviewed
Jul 10, 2022
Padarn
reviewed
Jul 10, 2022
rusty1s
approved these changes
Jul 10, 2022
Co-authored-by: Matthias Fey <[email protected]>
Co-authored-by: Matthias Fey <[email protected]>
|
Padarn
approved these changes
Jul 11, 2022
|
Thank you @lightaime. Looking forward to the follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request added support for the
normalization_resolverinMLP.