Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Data and HeteroData feature store get_all_tensor_attrs #4882

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

mananshah99
Copy link
Contributor

Resolves a bug in Data and HeteroData which results in get_all_tensor_attrs not filtering for true tensor attributes.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4882 (0b4894f) into master (cfda074) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4882      +/-   ##
==========================================
+ Coverage   82.76%   82.77%   +0.01%     
==========================================
  Files         329      329              
  Lines       17703    17704       +1     
==========================================
+ Hits        14652    14655       +3     
+ Misses       3051     3049       -2     
Impacted Files Coverage Δ
torch_geometric/data/data.py 91.43% <100.00%> (ø)
torch_geometric/data/hetero_data.py 94.13% <100.00%> (+0.01%) ⬆️
torch_geometric/data/storage.py 81.64% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfda074...0b4894f. Read the comment docs.

Copy link
Contributor

@yaoyaowd yaoyaowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mananshah99 mananshah99 merged commit 9fc80f3 into master Jun 28, 2022
@mananshah99 mananshah99 deleted the fix_data_fs branch June 28, 2022 23:22
@rusty1s
Copy link
Member

rusty1s commented Jun 29, 2022

@mananshah99 I just had a second look and this will somehow break PyG compatibility once we make the full switch to FeatureStore: Currently, every attribute will just get passed down as a reference to the mini-batch object (without indexing), in case it is neither a node or edge tensor. Let me know what you think!

@rusty1s
Copy link
Member

rusty1s commented Jun 30, 2022

@mananshah99 Shall we create an issue for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants