Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureStore.multi_get_tensor implementation #4853

Merged
merged 13 commits into from
Jun 24, 2022
Merged

Conversation

mananshah99
Copy link
Contributor

Implements a multi_get interface for FeatureStore and adjusts NeighborLoader to use this interface to enable batching requests to the feature store by group_name.

@mananshah99 mananshah99 requested a review from rusty1s June 23, 2022 22:04
@mananshah99 mananshah99 self-assigned this Jun 23, 2022
@mananshah99 mananshah99 changed the title FeatureStore.multi_get implementation FeatureStore.multi_get_tensor implementation Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4853 (8229d77) into master (c40b099) will increase coverage by 0.00%.
The diff coverage is 89.28%.

@@           Coverage Diff           @@
##           master    #4853   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         329      329           
  Lines       17699    17713   +14     
=======================================
+ Hits        14655    14668   +13     
- Misses       3044     3045    +1     
Impacted Files Coverage Δ
torch_geometric/data/feature_store.py 88.23% <83.33%> (-0.05%) ⬇️
torch_geometric/loader/utils.py 81.98% <100.00%> (+0.67%) ⬆️
torch_geometric/testing/feature_store.py 97.22% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40b099...8229d77. Read the comment docs.

Copy link
Contributor

@yaoyaowd yaoyaowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ZenoTan ZenoTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

test/data/test_feature_store.py Outdated Show resolved Hide resolved
torch_geometric/data/feature_store.py Outdated Show resolved Hide resolved
torch_geometric/data/feature_store.py Outdated Show resolved Hide resolved
torch_geometric/data/feature_store.py Outdated Show resolved Hide resolved
torch_geometric/data/feature_store.py Outdated Show resolved Hide resolved
torch_geometric/data/feature_store.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit e46fbb1 into master Jun 24, 2022
@rusty1s rusty1s deleted the feature_store_multi_get branch June 24, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants