Fix dimension in edge filter selection #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padarn
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4629 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 316 316
Lines 16677 16678 +1
=======================================
+ Hits 13823 13824 +1
Misses 2854 2854
Continue to review full report at Codecov.
|
rusty1s
approved these changes
May 12, 2022
|
Agreed, I'll do that. Edit: oh I see you did it for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix an issue reported in #4026. The filtering of attributes that have the same shape as
edge_indexare not handled correctly. This PR tries to fix that behaviour