Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Genius dataset #4570

Merged
merged 8 commits into from
May 6, 2022
Merged

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented Apr 30, 2022

This PR addresses part of the request in #4569 to add the missing datasets from LINKX.

This PR adds only the Genius dataset that seemed to be missing from PyG.

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #4570 (631fdd7) into master (926b5dc) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4570      +/-   ##
==========================================
- Coverage   82.91%   82.79%   -0.12%     
==========================================
  Files         315      315              
  Lines       16596    16594       -2     
==========================================
- Hits        13760    13739      -21     
- Misses       2836     2855      +19     
Impacted Files Coverage Δ
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/io/tu.py 93.58% <0.00%> (-2.57%) ⬇️
torch_geometric/nn/models/mlp.py 98.41% <0.00%> (-1.59%) ⬇️
torch_geometric/transforms/gdc.py 78.17% <0.00%> (-1.02%) ⬇️
torch_geometric/data/dataset.py 96.80% <0.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/rgat_conv.py 83.76% <0.00%> (-0.53%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926b5dc...631fdd7. Read the comment docs.

@Padarn Padarn changed the title Add missing LINKX datasets Add missing Genius dataset May 1, 2022
torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
torch_geometric/datasets/linkx_dataset.py Outdated Show resolved Hide resolved
@Padarn Padarn force-pushed the padarn/linkx-datasets branch from a0c12cc to 9b418a7 Compare May 4, 2022 05:05
torch_geometric/datasets/__init__.py Outdated Show resolved Hide resolved
torch_geometric/datasets/genius.py Outdated Show resolved Hide resolved
torch_geometric/datasets/genius.py Outdated Show resolved Hide resolved
torch_geometric/datasets/genius.py Outdated Show resolved Hide resolved
torch_geometric/datasets/genius.py Outdated Show resolved Hide resolved
@Padarn
Copy link
Contributor Author

Padarn commented May 6, 2022

Hey @rusty1s sorry for the earlier WIP - I was still figuring out how I thought it best to add these datasets.

I decided it was best to add them to the existing LINKXDataset as in my original PR - the reason being that these datasets are modified from the original datasets, and I thought it would be confusing if we named them individually.

I will add the other datasets in another PR if you're okay with this approach.

@rusty1s
Copy link
Member

rusty1s commented May 6, 2022

Thanks @Padarn. I agree with you. This approach sounds perfect to me!

@rusty1s rusty1s merged commit 9a16a0e into pyg-team:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants