Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LightningModule & LoggerCallback in GraphGym #4531

Merged
merged 43 commits into from
May 13, 2022

Conversation

aniketmaurya
Copy link
Contributor

Partially address 2nd task from the roadmap #4503.

Lightning Module implementation for model training/val/test step and implement Logger as PL Callback.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #4531 (f09f687) into master (6fd6f5b) will increase coverage by 0.03%.
The diff coverage is 92.64%.

❗ Current head f09f687 differs from pull request most recent head 27afa37. Consider uploading reports for the commit 27afa37 to get more accurate results

@@            Coverage Diff             @@
##           master    #4531      +/-   ##
==========================================
+ Coverage   82.88%   82.92%   +0.03%     
==========================================
  Files         316      316              
  Lines       16679    16747      +68     
==========================================
+ Hits        13825    13888      +63     
- Misses       2854     2859       +5     
Impacted Files Coverage Δ
torch_geometric/graphgym/logger.py 81.95% <89.36%> (+2.36%) ⬆️
torch_geometric/graphgym/model_builder.py 98.18% <100.00%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd6f5b...27afa37. Read the comment docs.

test/graphgym/test_graphgym.py Show resolved Hide resolved
test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/logger.py Outdated Show resolved Hide resolved
test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/logger.py Show resolved Hide resolved
torch_geometric/graphgym/logger.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/model_builder.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/model_builder.py Show resolved Hide resolved
torch_geometric/graphgym/model_builder.py Outdated Show resolved Hide resolved
@aniketmaurya aniketmaurya requested a review from rusty1s May 13, 2022 06:49
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/model_builder.py Show resolved Hide resolved
@rusty1s rusty1s changed the title Implement Lightning module & Logger Callback Implement LightningModule & LoggerCallback in GraphGym May 13, 2022
@rusty1s rusty1s merged commit c55729b into pyg-team:master May 13, 2022
@rusty1s
Copy link
Member

rusty1s commented May 13, 2022

Thank you! Looking forward to the follow-up contributions :)

@aniketmaurya aniketmaurya deleted the implement_module branch May 13, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants