Skip to content

Commit

Permalink
setup.py test is deprecated (#3317)
Browse files Browse the repository at this point in the history
* `setup.py test` is deprecated

* `setup.py test` is deprecated

* update

* update

Co-authored-by: rusty1s <[email protected]>
  • Loading branch information
jamesmyatt and rusty1s authored Oct 11, 2021
1 parent 6f6014e commit ad743c0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Run test-suite
run: |
python setup.py test
python -m pytest
- name: Generate coverage report
if: success()
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Hence, if you modify a Python file, you do not need to reinstall PyG again and a
5. Ensure that you have a working PyG installation by running the entire test suite with

```
python setup.py test
python -m pytest
```

In case an error occurs, please first check if all sub-packages ([`torch-scatter`](https://github.com/rusty1s/pytorch_scatter), [`torch-sparse`](https://github.com/rusty1s/pytorch_sparse), [`torch-cluster`](https://github.com/rusty1s/pytorch_cluster) and [`torch-spline-conv`](https://github.com/rusty1s/pytorch_spline_conv)) are on its latest reported version.
Expand All @@ -56,10 +56,10 @@ The PyG testing suite is located under `test/`.
Run the entire test suite with

```
python setup.py test
python -m pytest
```

or run individual test files, like `pytest --no-cov test/utils/test_convert.py`, for individual test suites.
or run individual test files, like `python -m pytest --no-cov test/utils/test_convert.py`, for individual test suites.

## Continuous Integration

Expand All @@ -79,7 +79,7 @@ If you do not want to format your code manually, we recommend to use [`yapf`](ht
2. Ensure that the entire test suite passes and that code coverage roughly stays the same. Please feel encouraged to provide a test with your submitted code.

```
python setup.py test
python -m pytest
```

## Building Documentation
Expand Down

0 comments on commit ad743c0

Please sign in to comment.