Python CMakeExtension
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenoTan
reviewed
Apr 22, 2022
ZenoTan
reviewed
Apr 22, 2022
ZenoTan
reviewed
Apr 22, 2022
| @@ -36,5 +87,7 @@ | |||
| 'dev': dev_requires, | |||
| }, | |||
| packages=find_packages(), | |||
| ext_modules=[CMakeExtension('libpyg')], | |||
There was a problem hiding this comment.
A little confused about naming it libpyg ('lib' as library prefix) but in python having torch.ops.pyg, and folder name pyg_lib. Is there a way to make them look consistent or specify them in doc?
There was a problem hiding this comment.
I currently do not see an easy way to do this.
lib*.sois the standard naming of librariespygis the namespacepyg_libis the Python package name.
I added a TODO here which we can look into later. Hope that works for you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
cmakebuild viapip install .