Fixes #63 #99
Merged
Fixes #63 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rather than current fit)
DarkFenX
added a commit
that referenced
this pull request
Jun 2, 2014
w9jds
pushed a commit
to w9jds/Pyfa
that referenced
this pull request
Aug 14, 2017
Catchup: Bugfixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #78 being on hold for now, I submit this request to fix many issues with projected fits. See #63 for details. There's a comment there that lays out the fixes and reasoning behind them. This has been tested as best as I could and I haven't noticed any regression between this and current stable release. However, it has fixed (or appears to fix - I haven't done any hand calculations) stats when projecting boosted fits.
There is one issue related to this fix (assuming we use the fits in #63):
Attach the Sleipnir to the Scythe, then project the Scythe to the Oracle. Set the Sleipnir as the squad booster to the Oracle and notice that the stats do not change. Tab to another tab, then tab back. Stats show correct values. If you open the Oracle fit in this configuration, the correct values are also shown.
This can be observed again by removing booster from Oracle (stats update), and then adding it back on (stats do not update until you tab or reopen fit).
Now, remove the booster from the Scythe. Now try to add / remove booster from Oracle. It seems to work without problem.
I believe this is a minor issue in the grand scheme of things. Without these changes, the current setup wouldn't give correct stats anyway, and this bug can be overlooked by reopening fit. I haven't nailed down exactly what causes it, however will continue to look. If this request is accepted, then I will make another issue for this bug. =)