Stop overriding copy/paste on macOS

[resinneublem]

For some reason this causes issues on wxMac 3.0.2.0. The menu accelerators hijack the shortcut and won't allow typical text manipulation inside of text controls.

There's some discussion about this happening for other people in:

• http://trac.wxwidgets.org/ticket/11320
• http://trac.wxwidgets.org/ticket/14953

I have not tested this in wxMac 2.8

This is to fix:

• Conflict with Copy/Paste shortcuts #490
• paste into notes #899
• Importing api key / Verification code for new char is not working on mac #877
• Paste from clipboard doesn't work when entering API for new character (OSX) #887

But I'm not sure if it reverts the fix for: #456 (comment)

[resinneublem]

Hrm, I can't even open the mac-deprecated version on macOS Sierra. The mac version opens just fine.

I ran: python dist.py -s ../../Pyfa-skel -b ../../Pyfa -d ../../ -z after cloning the Pyfa-skel repository.

I don't know what I'm doing wrong since the latest stable release downloaded from github opens just fine.

[resinneublem]

Hrm strange. Something happened and now I can't open the latest stable mac-deprecated now.

I blasted ~/.pyfa and tried again. Still fails.

I wonder if anyone else can open it. I don't have a non-Sierra machine to test.

[blitzmann]

Yeah, known issue. See #780

[blitzmann]

Could you run the pyfa.app/Contents/MacOS/pyfa binary from terminal and see if anything shows?

[resinneublem]

Could you run the pyfa.app/Contents/MacOS/pyfa binary from terminal and see if anything shows?

Immediately segfaults.

[blitzmann]

Immediately segfaults.

Yeah, and unfortunately I have no knowledge of how to handle those. =/ deprecated is basically dead in the water for 10.12+, which wouldn't be so bad if 10.11 didn't completely fuck performance for the regular wx3 build...

I'll be making build packages and testing this pull request soon, haven't forgotten about it :)

[blitzmann]

@resinneublem I haven't forgotten about this, I just still need to test it, especially to see hwo it interacts with the other issues. But we got a report in #954 that the new pre-release fixes the mac-deprecated version, can you test as well?

Thanks!

[blitzmann]

Unfortunately this isn't going to work... We have the following situation (tested on 10.7... yes I know this is extremely old)

(current master)
pyfa (wx2): Shortcuts overwrite default event. CMD+V in fit notes will try to import a fit from the clipboard, while CMD+C will not copy the current text but instead bring up the fit export dialog
pyfa (wx3): Exact same as above

(with this fix)
pyfa (wx2): Same as the above two
pyfa (wx3): CMD+V/C work as expected in text ctrls, but the to and from clipboard actions are disabled (reoccurance of #456)

We may just have to change the shortcuts for OS X to be something like SHIFT+CMD+C. At the same time, I'm going to try to make a real push in developing on OS X and making new binaries that don't suck for 10.11+, and hopefully getting rid of the wx2.8 build so we don't have to support it.

Unless we can find a way to only attach these shortcuts when a text control is not currently in focus...

[blitzmann]

I tested another version of this last night with no success. I'm going to close this PR since I don't think it's going to work. I did note (and this is in a comment on one of the issues) that this only happens in the packaged release - works fine when running through pycharm.

I don't know what the problem is, but I'm going to re-evaluate when I rebuild the binaries (either through py2app or the outstanding request to use pyinstaller).