Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Charges For Active Fit" market tree shortcut #2624

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

lunedis
Copy link
Contributor

@lunedis lunedis commented Jul 6, 2024

This pull requests adds a new entry in the market browser tree below "Recently Used Modules": "Charges for Active Fit".

image

It lists all charges that can be fitted to a module of the currently open fit tab. It can be used to e.g. quickly creat the needed cargo items. It is inspired by the similiar ingame ghost fitting feature.

I added a new entry, which needs a translation btw, with the same icon as "damage pattern". Benchmarks of the feature resulted in unconclusive results, the calculation of the needed modules took between 2 and 30ms on my machine. Updating the list might be the bottleneck, but I am not sure how it is implemented.

Happy for any feedback, first python / pyfa pull request in a while.

@lunedis lunedis marked this pull request as draft July 7, 2024 09:48
@lunedis lunedis marked this pull request as ready for review July 7, 2024 12:42
@DarkFenX DarkFenX merged commit 451b5d4 into pyfa-org:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants