Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SSO Login for Serenity and Singularity server's player #2590

Merged
merged 13 commits into from
Feb 26, 2024

Conversation

huangzheng2016
Copy link
Contributor

The new one fix some problem
Another Pr #2437
It was closed by me because of an error in committing the readme.

@DarkFenX
Copy link
Member

I am still yet to thoroughly look through the code. Preliminarily I have very few questions:

  • ali-esi.evepc.163.com - is it actual serenity ESI address, or is it some proxy to it?
  • I don't remember ESI auth flow well enough, so I don't remember if any kind of sensitive data is exposed to callback page hoster. Who is hoster of https://ali-esi.evepc.163.com/ui/oauth2-redirect.html ?

Later I will refresh how auth is handled. I want to do 2 things before next release: one bug related to progress dialog on windows and this merge request. so unless there are any issues with it, I plan to have it done next few days.

@huangzheng2016
Copy link
Contributor Author

huangzheng2016 commented Feb 26, 2024

It is the actual serenity ESI address, owned by NetEase (the game company that run an agent serenity
for Eve Online in China). No data is exposed to the callback page. If you need to test, you can contact me by email to provide the corresponding test account (or you can register one yourself)

@DarkFenX
Copy link
Member

No, I don't want to test (if it works for you - it's good for me already), I just don't want keys sensitive to players funneled through third parties.

@DarkFenX DarkFenX merged commit b8a58fc into pyfa-org:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants