-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the SSO Login for Serenity and Singularity server's player #2590
Conversation
# Conflicts: # gui/builtinPreferenceViews/pyfaEsiPreferences.py
I am still yet to thoroughly look through the code. Preliminarily I have very few questions:
Later I will refresh how auth is handled. I want to do 2 things before next release: one bug related to progress dialog on windows and this merge request. so unless there are any issues with it, I plan to have it done next few days. |
It is the actual serenity ESI address, owned by NetEase (the game company that run an agent serenity |
No, I don't want to test (if it works for you - it's good for me already), I just don't want keys sensitive to players funneled through third parties. |
The new one fix some problem
Another Pr #2437
It was closed by me because of an error in committing the readme.