Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented ability to split drone stacks by ship's available bandwidth #2237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Candyguitar
Copy link

I've implemented an additional option to 'Split Drone Stack to Fit Max Bandwidth' in the right click menu on drone stacks. This will match the size of the stack to the ship's bandwidth limits (or 5 if the limit allows for it) and create a new, inactive stack with the remaining drones. For example, an Algos has 35 mbit/s, so an active stack of 5 medium drones would be split into an active stack of 3 and an inactive stack of 2.

This is particularly useful when importing a fit from the game or the Eve University Wiki where drones might be stacked in higher amounts than the ship is capable of running, and you want to quickly view the DPS from a full flight of drones (or whatever the ship can support).

I've also accounted for situations where the user tries to split stacks of drones the ship can't support, e.g. 2 heavy drones in a Tormentor. Attempting to split a drone stack to fit bandwidth will show the user an error message informing them that this isn't possible.

Fits used to test my changes:

[Algos, Drone bandwidth test]

[Empty Low slot]
[Empty Low slot]
[Empty Low slot]

[Empty Med slot]
[Empty Med slot]
[Empty Med slot]

[Empty High slot]
[Empty High slot]
[Empty High slot]
[Empty High slot]
[Empty High slot]
[Empty High slot]

[Empty Rig slot]
[Empty Rig slot]
[Empty Rig slot]


Hammerhead I x5
Hammerhead I x6
Hammerhead I x4
[Tormentor, Drone bandwidth test]

[Empty Low slot]
[Empty Low slot]
[Empty Low slot]
[Empty Low slot]

[Empty Med slot]
[Empty Med slot]
[Empty Med slot]

[Empty High slot]
[Empty High slot]
[Empty High slot]

[Empty Rig slot]
[Empty Rig slot]
[Empty Rig slot]


Ogre I x2

Tristan fit taken from Eve Uni Wiki:

[Tristan, Solo Armor Brawl]
Light Neutron Blaster II
Light Neutron Blaster II

1MN Afterburner II
X5 Enduring Stasis Webifier
J5b Enduring Warp Scrambler

Damage Control II
Drone Damage Amplifier II
Small Ancillary Armor Repairer

Small Nanobot Accelerator I
Small Auxiliary Nano Pump I
Small Anti-Explosive Pump I


Hobgoblin II x8

Void S x320
Null S x320
Nanite Repair Paste x16

Dominix fit taken from Eve Uni Wiki:

[Dominix, Neuting high dps]
Heavy Gremlin Compact Energy Neutralizer
Heavy Gremlin Compact Energy Neutralizer
Heavy Gremlin Compact Energy Neutralizer
Heavy Gremlin Compact Energy Neutralizer
Drone Link Augmentor II
Drone Link Augmentor II

Large Micro Jump Drive
100MN Afterburner II
Heavy Capacitor Booster I
Omnidirectional Tracking Link II
Omnidirectional Tracking Link II

Damage Control II
1600mm Steel Plates II
Energized Adaptive Nano Membrane II
Energized Adaptive Nano Membrane II
Drone Damage Amplifier II
Drone Damage Amplifier II
Drone Damage Amplifier II

Large Explosive Armor Reinforcer I
Large Trimark Armor Pump I
Large Trimark Armor Pump I


Garde II x10
Warrior II x10
Hornet EC-300 x5
Valkyrie II x5

Navy Cap Booster 800 x1

@Candyguitar
Copy link
Author

Candyguitar commented Jul 22, 2020

I suspect I might have left a bug in droneSplitStack.py on line 57, as it always addresses the first stack of drones in the fit. Will have to wait until the morning before I take another look at it though, as it's past 1:30 AM in my timezone.

Edit: Fixed after testing again using this fit. In my first commit, splitting the light drone stack gave the same error message as trying to split the heavy drone stack, when the expected result was two light drone stacks:

[Tormentor, Bug test]

[Empty Low slot]
[Empty Low slot]
[Empty Low slot]
[Empty Low slot]

[Empty Med slot]
[Empty Med slot]
[Empty Med slot]

[Empty High slot]
[Empty High slot]
[Empty High slot]

[Empty Rig slot]
[Empty Rig slot]
[Empty Rig slot]


Hobgoblin I x4
Ogre I x5

@blitzmann
Copy link
Collaborator

Thanks! I'll take me a bit to evaluate thisince I'm focused on getting the i18n branch polished, so hang in there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants