Convert booster attribute to value before applying #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to boostermissilevelocitypenalty.py: Get booster attribute value using booster.getModifiedItemAttr() before attempting to apply it to avoid type error
ghost
mentioned this pull request
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 16.59% 16.59%
=======================================
Files 2318 2318
Lines 34373 34373
=======================================
Hits 5703 5703
Misses 28670 28670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to boostermissilevelocitypenalty.py:
Get booster attribute value using booster.getModifiedItemAttr()
before attempting to apply it to avoid type error
#1280
Previously we were not getting the booster attribute value and were instead attempting to apply to the attribute name as the value, which was causing a type error.
I have built and tested this fix on Windows 7 but don't have access to test on any other platforms.