Issue #1264 Don't attempt PopupMenu if getMenu returned False #1272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to characterEditor.py:
Added logic to prevent a crash when attempting to execute
self.PopupMenu(menu) when menu was False. This would occur in the
situation where there were no saved implant sets.
#1264
Fixed a scenario where spawnMenu in characterEditor.py was attempting to create a list of implant sets even when the list of implant sets contained no items which resulted in a crash.
The new behavior if there are no implant sets is to do nothing. I've put a trace in there but that might be unnecessary and could be removed.
I have built and tested this fix on Windows 7 but don't have access to test on any other platforms.