Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1264 Don't attempt PopupMenu if getMenu returned False #1272

Merged
merged 2 commits into from Sep 19, 2017
Merged

Issue #1264 Don't attempt PopupMenu if getMenu returned False #1272

merged 2 commits into from Sep 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2017

Change to characterEditor.py:
Added logic to prevent a crash when attempting to execute
self.PopupMenu(menu) when menu was False. This would occur in the
situation where there were no saved implant sets.


#1264

Fixed a scenario where spawnMenu in characterEditor.py was attempting to create a list of implant sets even when the list of implant sets contained no items which resulted in a crash.

The new behavior if there are no implant sets is to do nothing. I've put a trace in there but that might be unnecessary and could be removed.

I have built and tested this fix on Windows 7 but don't have access to test on any other platforms.

Change to characterEditor.py:
Added logic to prevent a crash when attempting to execute
self.PopupMenu(menu) when menu was False. This would occur in the
situation where there were no saved implant sets.
@codecov-io
Copy link

codecov-io commented Aug 19, 2017

Codecov Report

Merging #1272 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   16.59%   16.59%   -0.01%     
==========================================
  Files        2318     2318              
  Lines       34373    34375       +2     
==========================================
  Hits         5703     5703              
- Misses      28670    28672       +2

@blitzmann blitzmann merged commit 3625b43 into pyfa-org:master Sep 19, 2017
@blitzmann
Copy link
Collaborator

Thanks! I noticed some other issues with the implant context menu in the character editor, went ahead and applied those fixes as well #1284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants