Re-introduce Command Fit State #1074
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1074 +/- ##
===============================================
- Coverage 10.19% 10.19% -0.01%
===============================================
Files 2139 2139
Lines 31402 31404 +2
===============================================
Hits 3203 3203
- Misses 28199 28201 +2Continue to review full report at Codecov.
|
gui/builtinViewColumns/state.py
Outdated
| if projectionInfo is None: | ||
| # can't use isinstance here due to being prevented from importing CommandView. | ||
| # So we do the next best thing and compare Name of class. | ||
| if type(self.fittingView).__name__ == "CommandView": |
There was a problem hiding this comment.
Could use:
self.fittingView.__class__.__name__
Not sure it's any faster though.
There was a problem hiding this comment.
True, I'll change is as it's not a function call. Thanks!
| return -1 | ||
| if projectionInfo.active: | ||
| if info.active: |
There was a problem hiding this comment.
info is used all over the place (281 occurrences). I liked projectionInfo better. :)
There was a problem hiding this comment.
Well it's no longer projection info. It can be command info now, so it needs to be more generic. It's a variable scoped to this function, so there shouldn't be any issue in determining the meaning of it.
Simple QoL improvement / a fix for a regression dating back to November.
Bit of background: I disabled the state column for the Command / Fleet view when we made the change over to the new command burst mechanics. The reason behind this is because the State column, which controls which image is show to represent state of item, only received
stuff. Normally we check whatstuffis, and figure out what to do from there (eg: ifstuffis a module, check the modules state and display an image that works).The problem originally with command fits is that it shares the same
stufftype as projected fits. So there wasn't a way to differentiate a projected fit from a command fit in the State class.But holy shit, this was super easy after taking a look at it again tonight. We can't differentiate on
stuff, but what we do have is access to the calling view. So to re-enable the State column for command view, we check to see if we're calling from command or projected, then get it's information, then display based on active flag.