Missing icon files

[blitzmann]

This has been bugging me. Market browser has a few missing icons. In the eve.db file, the bad icon file is usually listed as res:/UI..., which leads me to think that there is a conversion issue from eve data -> pyfa data, although I haven't looked into this at all.

Some missing icons:

---

[blitzmann]

It seems that even CCP can't get their shit together. You can see missing icons eve on EVElopedia. It's kinda a mess

---

For missing rig icons

Most icons in the EVE Client and database dump point to an iconFile that looks like this: 34_65. These are fairly easily translated into the official icon pack dump. However, some icons pointed to EVE Client files such as res:/UI/Texture/Icons/123_124_23.png. Not exactly sure why CCP has two different formats.

I'm going to make a pull request that may or may not be the best way, or most future proof way, to fix this. Please refer to said pull request for pros/cons

A proper and sexier fix would be to create a script that parses through everything, and pulls the icons from the official release and auto-converts it and everything. It seems that all icon file management in Pyfa is done manually. But this is pretty low priority methinks as icons don't change often.

---

For missing racial subsystem icons

Same deal as above. However, the icons that are CCP designated for these market groups look odd. The icons we currently use for race selector on ship browser look much better and will probably be used in release. See below for comparison:

CCP release:

Change to:

---

For drone icons

The market groups and drones themselves simply don't have an icon assigned to them. Looking into a fix -- possibly a an override in the icon fetching code

[blitzmann]

After discussion with Kadesh, merged the pull request into master. As for drones, we'll be leaving them as-is for now. Drones in the client don't have an icon, they have a render. Still looks weird in pyfa as there is a space for the missing icon -- that's a separate issue that may or may not be fixed...