Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citadel import fails #749

Closed
Ebag333 opened this issue Sep 22, 2016 · 1 comment
Closed

Citadel import fails #749

Ebag333 opened this issue Sep 22, 2016 · 1 comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@Ebag333
Copy link
Contributor

Ebag333 commented Sep 22, 2016

Looks like when we hit like 312 of port.py we end up getting None for fit.ship

        try:
            ship = sMkt.getItem(shipType)
            fit.ship = Ship(ship)
            fit.name = fitName
        except:
            return

Playing around a little with this in #744

@blitzmann
Copy link
Collaborator

Yeah, it's because we used to assume everything is a ship. You can fix this with a try / catch, like how we do when creating a new ship:

https://github.com/pyfa-org/Pyfa/blob/master/service/fit.py#L161

Also, for pull requests, try to limit one request per issue if possible. Lumping multiple things together gets hairy ;)

@blitzmann blitzmann added the bug Confirmed to be a bug label Sep 23, 2016
blitzmann added a commit that referenced this issue Sep 27, 2016
@blitzmann blitzmann added the fixed This issue has been fixed! Oh joy! label Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

2 participants