We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like when we hit like 312 of port.py we end up getting None for fit.ship
port.py
None
fit.ship
try: ship = sMkt.getItem(shipType) fit.ship = Ship(ship) fit.name = fitName except: return
Playing around a little with this in #744
The text was updated successfully, but these errors were encountered:
Yeah, it's because we used to assume everything is a ship. You can fix this with a try / catch, like how we do when creating a new ship:
https://github.com/pyfa-org/Pyfa/blob/master/service/fit.py#L161
Also, for pull requests, try to limit one request per issue if possible. Lumping multiple things together gets hairy ;)
Sorry, something went wrong.
Fit Citadel imports (#749)
becb3d4
No branches or pull requests
Looks like when we hit like 312 of
port.py
we end up gettingNone
forfit.ship
Playing around a little with this in #744
The text was updated successfully, but these errors were encountered: