-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta Compare Iterations #646
Comments
This is something I think about every few months... The problem here mostly has to do with the general layout of pyfa - this is one area where I think eft has a leg up on us, as two different fits can be shown side by side. The proper way would be to allow someone to be able to drag out a fitting tab and pop a new window with it. Another way would be to simply open a stats view of a fit into another window without the fitting view (in which case, might as well get the fitting view as well...). I honestly don't know how big of a scope those changes would be. Popping a new window with another fitting view is not in itself difficult, but decoupling all the events surrounding the fitting view (fit change, character change, state change, etc) would be a bitch and require quite a lot of refactoring to eliminate the assumption of only one view. As for your idea or what it might look like, I'm not sure I understand. Do you mind elaborating? |
I pulled an example from wowhead.com's item comparison tool: http://puu.sh/pq94u/43746ddd6f.png That is pretty much what I'd love to see for items and/or ships. The third column in this example is the worse than the first column, so all values lower than the primary ship you compare it to should be red if worse, green if better. Does that make sense? |
Here's a thing I want to do some tweak ofc (column sorting, highlighting min/max, etc), but the base is there. Working off branch https://github.com/pyfa-org/Pyfa/tree/feature/item-compare |
I've added this feature as it is in the above image. The following logic is used:
This feature will be released as-is with the June release next week. I'm going to mark this as done until then. However, at that time I'll gear this issue as more of an iteration tracker for this feature, as there are still some things that I wish to get done for it. Namely:
|
Looks great! :-) I am currently really occupied irl but when that's sorted I'll get back to 2016-06-24 5:24 GMT+02:00 Ryan Holmes [email protected]:
|
(Sorry for the many tickets in a row but I feel each subject deserves its own ticket to make them more managable!)
Whenever I am trying to design ship fittings it is fairly inconvenient to compare the differences between two setups in a clear fashion. I am curious to know if it's difficult to build a functionality that allows you to compare the stats of two fittings side-by-side, so that it's easier to both share (via screenshots) and gives a better insight in ship fits.
One way I can envision this is that you have one window with an item or fit, and it tells you the differences in final stats for a certain character selected next to it. If I were to gain 100m/s with the selected fit to compare, that it shows clearly how much difference there is.
The text was updated successfully, but these errors were encountered: