Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max attribute value #620

Closed
blitzmann opened this issue May 22, 2016 · 5 comments
Closed

Max attribute value #620

blitzmann opened this issue May 22, 2016 · 5 comments
Labels
fixed This issue has been fixed! Oh joy! investigate Issue needs more investigation and discussion before a solve is implemented

Comments

@blitzmann
Copy link
Collaborator

blitzmann commented May 22, 2016 •
edited
Loading

Something seems to be wrong with at least the max targeting range. We seem to still be checking on maxAttributeID, which for targeting range is set to 300KM. This might not be a thing anymore, and might be due to data that we are pulling from the client but which isn't used any longer. Need to look into this.

https://forums.eveonline.com/default.aspx?g=posts&m=6498948#post6498948
@blitzmann
Copy link
Collaborator Author

At this time, I think I am going to hardcode it to simply ignore the max targeting range cap until I can figure out the root of the problem.

blitzmann added a commit that referenced this issue May 22, 2016
@blitzmann
Remove cap from target range (#620)
de6c843
@blitzmann blitzmann added bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! labels May 22, 2016
@JoshuaNotowitz
Copy link

I just checked ingame and the max target range for subcaps is 300.

@MrNukealizer
Copy link
Contributor

Yes, the targeting range cap is 300km for everything except carriers and super carriers, so that seems accurate.

@blitzmann
Copy link
Collaborator Author

I'm going to reopen this until I can figure out how to best deal with this. CCP may have it hardcoded because I don't see an attribute about ignoring certain attributes...

@blitzmann blitzmann reopened this May 27, 2016
@blitzmann blitzmann added investigate Issue needs more investigation and discussion before a solve is implemented fixed This issue has been fixed! Oh joy! and removed bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! labels May 27, 2016
@blitzmann
Copy link
Collaborator Author

e70ea67 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed This issue has been fixed! Oh joy! investigate Issue needs more investigation and discussion before a solve is implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MrNukealizer @blitzmann @JoshuaNotowitz