Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDAs not stacking penalized for fighters #576

Closed
lunedis opened this issue May 1, 2016 · 1 comment
Closed

DDAs not stacking penalized for fighters #576

lunedis opened this issue May 1, 2016 · 1 comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@lunedis
Copy link
Contributor

lunedis commented May 1, 2016

image

Proposed fix:
adding ", stackingPenalties=True" to the 3 lines in the effect

https://github.com/pyfa-org/Pyfa/blob/master/eos/effects/modulebonusdronedamageamplifier.py#L7
lunedis added a commit to lunedis/Pyfa that referenced this issue May 1, 2016
@lunedis
Fixing Drone Damage Amplifier fighter stacking issue pyfa-org#576
3ce5f69
blitzmann added a commit that referenced this issue May 1, 2016
@blitzmann
Merge pull request #578 from lunedis/dda_stacking_fix
a1d64ac 
Fixing Drone Damage Amplifier fighter stacking issue #576
@blitzmann blitzmann added bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! labels May 1, 2016
@blitzmann
Copy link
Collaborator

For those interested in fixing this manually until a point release is made, replace contents of pyfa/library.zip/eos/effects/modulebonusdronedamageamplifier.py with this:
https://raw.githubusercontent.com/pyfa-org/Pyfa/a1d64acff4524af486df080bb1b427755c3a6670/eos/effects/modulebonusdronedamageamplifier.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blitzmann @lunedis