-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTPS for jQuery CSS and JS #549
Comments
I don't see a problem with this, just need to test it out. The HTML page needs a little work as a whole to be honest, but I figured it's use has declined since the introduction of Copy from Clipboard in the EVE client. |
Much obliged. At least I still use the HTML export functionality; in fact, I even wrote a small AutoIt script to do it automatically and send it to my web server... Some arguments as to why I think you should take the time to implement this: the search function of the web page is pretty handy and yes, pyfa itself also has a search function, but for that, I need to click first and with the web page I can just start typing (I'm a lazy bastard, I know). Also, with the HTML export, I have this data available on whatever computer, as long as I have a web browser, which is just awesome IMHO. So, I hope I have convinced you to implement it in your code, test it and have it ready in a future version of pyfa... By the way, I love pyfa; when pyfa became available, I stopped using EFT. |
<3 Also, in case you didn't know, there is an option in the user preferences to automatically generate the HTML document whenever a change is made. Use with caution though - it's a threaded processes which doesn't block the GUI, but we've always and reports of it possibly causing crashes (most likely because it's accessing database at same time as main program). I've never had the motivation to look into it as it's fairly elusive to reproduce. I've used it without issue before, but others have a lot of problems with it. YMMV. |
Rather than switching to https links, It would be better to use protocol
On 30 March 2016 at 01:58, Ryan Holmes [email protected] wrote:
|
@narthollis I don't think that would work when opening the file locally. The protocol would be |
On 30 March 2016 at 09:11, Ryan Holmes [email protected] wrote:
|
Done. Also fixed an issue where it wasn't loading in Chrome - who knows for how longs it's been like that x_x |
…e that caused page to not load in Chrome
Nice going, guys, thanks very much! |
I'm using the exported HTML page on a web site with HTTPS.
Because the included stylesheet and JavaScript files from jQuery are HTTP URLs, they get blocked by at least Mozilla Firefox and Google Chrome, as including non-SSL content from an SSL web page is considered to be insecure.
Because those files are also available via HTTPS (https://code.jquery.com/mobile/1.4.2/jquery.mobile-1.4.2.min.css, https://code.jquery.com/jquery-1.11.0.min.js and https://code.jquery.com/mobile/1.4.2/jquery.mobile-1.4.2.min.js are all reachable, I checked), I would like for you to consider changing that in the exported HTML.
In that case it would always work, regardless whether this HTML file is viewed on a website with or without SSL.
The text was updated successfully, but these errors were encountered: