Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fighters maximum velocity not correct #1128

Closed
dado023 opened this issue Apr 17, 2017 · 28 comments
Closed

Fighters maximum velocity not correct #1128

dado023 opened this issue Apr 17, 2017 · 28 comments
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@dado023
Copy link

dado023 commented Apr 17, 2017

This is what Pyfa shows: pyfa_2017-04-17_03-58-34

and this is what in game shows:
exefile_2017-04-17_04-02-22

I hope this can be fixed.

Cheers

@Ebag333
Copy link
Contributor

Ebag333 commented Apr 17, 2017

Which fighter is this?

What's the fit of the carrier?

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

Nidhoggur(fighter: Templar I) + 2xDrone Navigation Computer II + 3xFighter Support Unit II

@Ebag333
Copy link
Contributor

Ebag333 commented Apr 17, 2017

And which fighter?

Dragonfly II is closest in speed, but not the one you have selected.

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

@Ebag333 its Templar I

@blitzmann
Copy link
Collaborator

@dado023 What are the skill levels involved? I believe Minmatar Carrier, Drone Navigation, and Light Fighters are the ones that affect the speed for this particular setup.

Also, in the future, it would be helpful if you could post the EFT fitting of it. Just makes it easier.

With an All 5 character I'm showing 2824, which is almost equal to the value you state you get in the client.

image

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

@blitzmann yes, i get the same results in Pyfa, but in game velocity is higher....see screenshot from first post.

@blitzmann
Copy link
Collaborator

@blitzmann yes, i get the same results in Pyfa, but in game speeds are higher.

But your pyfa screen shows 2651... >_>

As for the small discrepancy in 2824 vs 2888, will take a look. I would would recommend removing all affecting modules from the fit in game and see if, from just your skills, you get a value that matches pyfa. From there, we can try to pinpoint where the calc is going off by slowly adding on additional modules.

@blitzmann
Copy link
Collaborator

Also (and off topic), you have very pretty screenshots. Which program is that?

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

@blitzmann
Copy link
Collaborator

blitzmann commented Apr 17, 2017

@dado023 ah, thanks!

Anyway, yeah, if you can do some research on your end by removing modules from in game and pyfa and seeing where it goes wrong, that would be great. If not, I'll log into SISI tomorrow to poke around at it and see what I can find. :)

@Ebag333 if you have any thoughts, let me know. It looks like it could be a stacking penalty being applied or something

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

k, i just striped in game 3xFighter Support Unit II and i get the same speed in pyfa as in game, without those modules.....so, i am assuming there is something wrong with calculation related to Fighter Support Unit II modules

@blitzmann
Copy link
Collaborator

blitzmann commented Apr 17, 2017

Thanks, that helps narrow it down. :)

Will let you know when there is a fix for it / I have more info

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

k, i just did manual calculation following these penalties:

1st mod: 100.0% effectiveness
2nd mod: 86.9%
3rd mod: 57.1%
4th mod: 28.3%
5th mod: 10.6%

I get exact same result in my calculator as it is in Pyfa....huh.
It looks like game does wrong calculation, or modules are regarded as different type...weird

@blitzmann
Copy link
Collaborator

blitzmann commented Apr 17, 2017

Yeah, not sure... I turned stacking penalties off just to see, and pyfa shows 3177 now, which is totally not correct.

Can you post the ingame and pyfa values for 1, 2, and 3 FSUs? I can then take that data to some ccp devs and try to figure out what's going on.

It could also be that pyfa is applying some effects in the wrong order... can take a look into that as well.

@blitzmann
Copy link
Collaborator

Also, I'm assuming that after you remove the FSUs you're also getting 2668 for the speed of the Templar I's?

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

@blitzmann with all FSUs disabled, i get 2504
image

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

@blitzmann oh, please dont go to devs, then CCP will fix/nerf it, so fighters will be slow :(

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

In any case, game does those 3 FSUs and calculates as 3 modules, not calculated with 2xDNC for total of 5 velocity modules, .....

Following 3xFSU calculation penalties:

1st mod: 100.0% effectiveness
2nd mod: 86.9%
3rd mod: 57.1%

and

Following 2xDNC calculation penalties:

1st mod: 100.0% effectiveness
2nd mod: 86.9%

@blitzmann
Copy link
Collaborator

@blitzmann with all FSUs removed, i get 2504

This is not what I get in pyfa...

Can you list your skill levels for these:

Minmatar Carrier
Drone Navigation
Light Fighters

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

Minmatar Carrier 4
Drone Navigation 4 5
Light Fighters 4

@blitzmann
Copy link
Collaborator

ah, that could explain some things. Give me a sec to plug those in

@blitzmann
Copy link
Collaborator

blitzmann commented Apr 17, 2017

BTW, DNC requires level 5 Drone Navigation... so how are you able to fit this in game?

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

oh sry, indeed, i have Drone Navigation 5

@blitzmann
Copy link
Collaborator

Okay... so to summarize

[Nidhoggur, Nidhoggur fit]

[Empty Low slot]
[Empty Low slot]
[Empty Low slot]
[Empty Low slot]
[Empty Low slot]

Drone Navigation Computer II
Drone Navigation Computer II
[Empty Med slot]
[Empty Med slot]
[Empty Med slot]
[Empty Med slot]

Fighter Support Unit II /OFFLINE
Fighter Support Unit II /OFFLINE
Fighter Support Unit II /OFFLINE
[Empty High slot]
[Empty High slot]

[Empty Rig slot]
[Empty Rig slot]
[Empty Rig slot]


Templar I x9

Having the the FSUs offline gets me 2504, same as you. So we're on the same page with that. :)

Can you get me the numbers from both pyfa and in game having 1 FSU online, then 2 FSU, then 3 FSU? I want to see what sort of discrepancy there is with successive modules being onlined.

Thanks for taking the time to troubleshoot this with me :)

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

as i mentioned here #1128 (comment)

For FSUs just follow the penalty factors, to get in game calculated velocities.

@blitzmann
Copy link
Collaborator

Ah, thanks. Sorry, misinterpreted that comment.

However, I think I've got it:

image

:D

I still need to play around with it to ensure this is the proper fix, but I know what's going on now. Thanks again for looking into this with me. I may have a few more questions as I progress

@dado023
Copy link
Author

dado023 commented Apr 17, 2017

Oh well, english isn't my native language...i am trying my best :) .......looking at your screenshot, new equation seems to output correct velocity.

@blitzmann blitzmann added the bug Confirmed to be a bug label Apr 17, 2017
@blitzmann
Copy link
Collaborator

No problem at all man, thanks for the bug report :)

blitzmann added a commit to blitzmann/Pyfa that referenced this issue Apr 17, 2017
@blitzmann blitzmann added the fixed This issue has been fixed! Oh joy! label Apr 17, 2017
Ebag333 pushed a commit to Ebag333/Pyfa that referenced this issue Apr 17, 2017
Ebag333 added a commit to Pyfa-fit/Pyfa-fit that referenced this issue Apr 18, 2017
Fix for pyfa-org#1128 - these modifiers are in their own pen-group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

3 participants