Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Managed Kubernetes in CAPI proposal #14

Closed
wants to merge 1 commit into from
Closed

Conversation

pydctw
Copy link
Owner

@pydctw pydctw commented Jul 25, 2022

Co-authored-by: Richard Case [email protected]
Co-authored-by: Winnie Kwon [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@pydctw pydctw force-pushed the proposal-managed-k8s branch 2 times, most recently from 7924fc9 to 65b73ba Compare July 26, 2022 21:04
@pydctw
Copy link
Owner Author

pydctw commented Jul 26, 2022

@richardcase, I experimented with having a proposed option and alternatives considered but it just doesn't read well for me.

I think it is because we already have existing implementations and proposing option 3 without mentioning option 1 or option 2 first makes it difficult to understand why we even considered option 1 or option 2 in the first place.

So I have decided to leave them as is but restructured the proposal a little bit

  • Separated out Managed Node Groups for Worker Nodes section from Managed Kubernetes API Design Approaches and moved Recommendation section before Managed Node Groups for Worker Nodes as our Recommendation is more focused on Managed Kubernetes API Design Approaches.
  • Reworded Other Consideration for CAPI section based on comments.

Let me know what you think. If you find a better way to structure the proposal, I am all for it.

I will squash the commit and open the PR to CAPI repo before tomorrow's office hr based on your feedback.

@richardcase
Copy link
Collaborator

I agree i think it makes sense to keep the structure as it is....i think it flows better.

@pydctw
Copy link
Owner Author

pydctw commented Jul 27, 2022

Thanks for the formatting and updates. It looks much better.
Squashing the commit and opening a PR in CAPI. Will update a link in CAPI office hr notes.

@pydctw pydctw force-pushed the proposal-managed-k8s branch from 8426a9b to e0419b8 Compare July 27, 2022 15:02
Co-authored-by: Richard Case <[email protected]>
Co-authored-by: Winnie Kwon <[email protected]>
@pydctw pydctw force-pushed the proposal-managed-k8s branch from e0419b8 to 9a1b9b7 Compare July 27, 2022 15:05
@pydctw
Copy link
Owner Author

pydctw commented Jul 27, 2022

Closing this one

@pydctw pydctw closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants