Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit serialization error message #9916

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Edit serialization error message #9916

merged 2 commits into from
Dec 30, 2024

Conversation

VeckoTheGecko
Copy link
Contributor

Fixes #4926

I thought it would be better to throw an "or" in the error message rather than add a parameter to the function.

@max-sixty max-sixty merged commit 33bf5e8 into pydata:main Dec 30, 2024
38 checks passed
@max-sixty
Copy link
Collaborator

Thanks @VeckoTheGecko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments topic-error reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serializing a Dataset to_zarr prints error message for NetCDF
3 participants
@VeckoTheGecko @max-sixty @headtr1ck