Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interpolation when non-numeric coords are present. #9887

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Fix interpolation when non-numeric coords are present. #9887

merged 4 commits into from
Dec 14, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Dec 13, 2024 •
edited
Loading

We were calling align with no indexers, which just returned the input object

@dcherian dcherian requested a review from Illviljan December 13, 2024 18:27
@dcherian dcherian force-pushed the fix-interp-non-numeric branch from 766b6b1 to 0c2f03d Compare December 13, 2024 18:31
Illviljan
Illviljan approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@Illviljan Illviljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dcherian ! The old version seems to have only worked on the 1d case. I added a test for 1d as well.

@Illviljan Illviljan enabled auto-merge (squash) December 14, 2024 08:23
@Illviljan Illviljan merged commit 755581c into pydata:main Dec 14, 2024
28 checks passed
@dcherian dcherian deleted the fix-interp-non-numeric branch December 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan approved these changes

Assignees
No one assigned
Labels
topic-interpolation
Projects
None yet
Milestone
No milestone
2 participants
@dcherian @Illviljan