Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ensure_dtype_not_object from conventions to backends #9828

Merged
merged 3 commits into from
Dec 2, 2024
Merged

move ensure_dtype_not_object from conventions to backends #9828

merged 3 commits into from
Dec 2, 2024

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Nov 26, 2024 •
edited
Loading

This is an internal change, moving non-CF related ensure_dtype_not_object-function from conventions to backends. Tests moved accordingly.

This was a longstanding ToDo which should now be resolved.

  • Tests fixed
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@kmuehlbauer kmuehlbauer marked this pull request as ready for review November 26, 2024 09:27
dcherian
dcherian approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me!

@kmuehlbauer
Copy link
Contributor Author

@shoyer You've added that ToDo in #165 over ten years ago 😮. You might want to have a look if this ended up in the right spot, finally 😎. Thanks!

@kmuehlbauer kmuehlbauer added plan to merge Final call for comments run-upstream Run upstream CI labels Dec 2, 2024
@kmuehlbauer kmuehlbauer merged commit 14a544c into pydata:main Dec 2, 2024
36 of 41 checks passed
@kmuehlbauer kmuehlbauer deleted the ensure_dtype_not_object branch December 2, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments run-upstream Run upstream CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmuehlbauer @shoyer @dcherian