-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupBy(multiple strings) #9414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
str-unique-grouper
branch
from
August 30, 2024 04:33
abfb63c
to
ce841d5
Compare
keewis
reviewed
Aug 30, 2024
keewis
reviewed
Aug 30, 2024
max-sixty
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @dcherian !
(Code looks much more elegant than when I glanced yesterday, nice clean up :) )
max-sixty
reviewed
Aug 30, 2024
dcherian
added
plan to merge
Final call for comments
and removed
plan to merge
Final call for comments
labels
Aug 30, 2024
Co-authored-by: Maximilian Roos <[email protected]>
dcherian
commented
Aug 31, 2024
docs failure looks unrelated |
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
* Group by multiple strings Closes pydata#9396 * Fix typing * some more * fix * cleanup * Update xarray/core/dataarray.py * Update docs * Revert "Update xarray/core/dataarray.py" This reverts commit fafd960. * update docstring * Add docstring examples * Update xarray/core/dataarray.py Co-authored-by: Maximilian Roos <[email protected]> * Update xarray/core/dataset.py * fix assert warning / error * fix assert warning / error * Silence RTD warnings --------- Co-authored-by: Maximilian Roos <[email protected]> Co-authored-by: Maximilian Roos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9396
Quite messy, and
typing is broken atm (help!)