Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupBy(multiple strings) #9414

Merged
merged 16 commits into from
Sep 4, 2024
Merged

GroupBy(multiple strings) #9414

merged 16 commits into from
Sep 4, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Aug 30, 2024

Closes #9396

Quite messy, and typing is broken atm (help!)

@dcherian dcherian requested a review from max-sixty August 30, 2024 04:30
@dcherian dcherian force-pushed the str-unique-grouper branch from abfb63c to ce841d5 Compare August 30, 2024 04:33
xarray/core/dataarray.py Outdated Show resolved Hide resolved
xarray/core/dataset.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dcherian !

(Code looks much more elegant than when I glanced yesterday, nice clean up :) )

@dcherian dcherian added plan to merge Final call for comments and removed plan to merge Final call for comments labels Aug 30, 2024
Co-authored-by: Maximilian Roos <[email protected]>
@max-sixty
Copy link
Collaborator

docs failure looks unrelated

@dcherian dcherian added the plan to merge Final call for comments label Sep 3, 2024
@dcherian dcherian merged commit 2783255 into pydata:main Sep 4, 2024
28 checks passed
@dcherian dcherian deleted the str-unique-grouper branch September 4, 2024 15:34
hollymandel pushed a commit to hollymandel/xarray that referenced this pull request Sep 23, 2024
* Group by multiple strings

Closes pydata#9396

* Fix typing

* some more

* fix

* cleanup

* Update xarray/core/dataarray.py

* Update docs

* Revert "Update xarray/core/dataarray.py"

This reverts commit fafd960.

* update docstring

* Add docstring examples

* Update xarray/core/dataarray.py

Co-authored-by: Maximilian Roos <[email protected]>

* Update xarray/core/dataset.py

* fix assert warning / error

* fix assert warning / error

* Silence RTD warnings

---------

Co-authored-by: Maximilian Roos <[email protected]>
Co-authored-by: Maximilian Roos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .groupby(['foo', 'bar']) as sugar for .groupby(foo=UniqueGrouper(), bar=UniqueGrouper())
3 participants