fix the failing pre-commit.ci runs
#9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since my knowledge on typing is very light, I'll leave that to someone else to pick up. Also, does anyone use the In any case, I'll go ahead and merge this now, since it unblocks a couple of other PRs. |
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Aug 30, 2024
* use `types-setuptools` instead of the deprecated `types-pkg_resources` * [skip-ci][skip-rtd]
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Aug 30, 2024
* main: Accessibility: Add keyboard handling for XArray HTML view (pydata#9412) [pre-commit.ci] pre-commit autoupdate (pydata#9316) [skip-ci] Speed up docs build by limiting toctrees (pydata#9395) fix the failing `pre-commit.ci` runs (pydata#9411) Update benchmarks.yml (pydata#9406) GroupBy(multiple groupers) (pydata#9372) Encode/decode property tests use variables() (pydata#9401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the disabled
mypyhook we explicitly installtypes-pkg_resources. This project has been yanked on PyPI, with the notice that instead we should usetypes-setuptools. This applies that change, but if I remember correctly, we stopped depending onsetuptools/pkg_resourcesa while ago, so we might also be able to just remove that?