Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate squeeze kwarg to groupby #9280

Merged
merged 7 commits into from
Jul 26, 2024

Conversation

dcherian
Copy link
Contributor

Closes #9279
Closes #1460
Closes #2157

This was deprecated in January, so perhaps a bit soon.

OTOH this has been the source of some quite confusing behaviour (see linked issues above).

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

doc/whats-new.rst Outdated Show resolved Hide resolved
xarray/core/groupby.py Outdated Show resolved Hide resolved
@dcherian dcherian added the plan to merge Final call for comments label Jul 26, 2024
doc/whats-new.rst Outdated Show resolved Hide resolved
@dcherian dcherian enabled auto-merge (squash) July 26, 2024 22:44
@dcherian dcherian merged commit 53c5634 into pydata:main Jul 26, 2024
28 checks passed
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, great to see this!


Deprecations
~~~~~~~~~~~~
- The ``squeeze`` kwarg to ``groupby`` is completely deprecated. This has been the source of some quite confusing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might phrase this as "no longer supported" rather than "completely deprecated".

@dcherian dcherian deleted the delete-groupby-squeeze branch July 27, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan to merge Final call for comments
Projects
None yet
3 participants