Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #8770: Improved frequency parameter logic to set it to 'D' only if periods, start, or end are None. #8774

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Fixing issue #8770: Improved frequency parameter logic to set it to 'D' only if periods, start, or end are None. #8774

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2eb97a3
Fixing issue #8770: Improved frequency parameter logic to set it to '…
rjavierch Feb 21, 2024
39254e2
Addressed feedback: Updated default argument handling in cftime_range…
rjavierch Feb 22, 2024
1c384b3
Update doc/whats-new.rst
rjavierch Feb 22, 2024
a6d0391
Update xarray/tests/test_cftime_offsets.py
rjavierch Feb 22, 2024
439816b
Update xarray/tests/test_cftime_offsets.py
rjavierch Feb 22, 2024
8f47a0c
Input argument period included in test_cftime_range_no_freq and test_…
rjavierch Feb 22, 2024
9196cd2
Update doc/whats-new.rst
rjavierch Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion xarray/coding/cftime_offsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ def date_range(
start=None,
end=None,
periods=None,
freq="D",
freq=None,
tz=None,
normalize=False,
name=None,
Expand Down Expand Up @@ -1218,6 +1218,9 @@ def date_range(
"""
from xarray.coding.times import _is_standard_calendar

if freq is None and any(arg is None for arg in [periods, start, end]):
freq = "D"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry on second thought could you move this logic into cftime_range (defined a little farther up in this file)? That way we can harmonize the default arguments across pandas.date_range, xarray.cftime_range, and xarray.date_range.


if tz is not None:
use_cftime = False

Expand Down
Loading